Bug 225963: Merge Review: kdelibs Product: Fedora Extras Version: devel Component: Package Review Rex Dieter <rdieter@xxxxxxxxxxxx> has denied Rex Dieter <rdieter@xxxxxxxxxxxx>'s request for fedora-review: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225963 ------- Additional Comments from Rex Dieter <rdieter@xxxxxxxxxxxx> On first glance (otherwise, looking good): * SHOULD omit Requires: cups ... Obsoletes: %{name}2 Obsoletes: kdesupport Obsoletes: kdoc that's all ancient history, no need, imo, to carry the baggage anymore. * -devel pkg SHOULD Requires: qt-devel unversioned here is ok, main pkg already includes Requires: qt >= EVR omit legacy crud: Obsoletes: kdesupport-devel * SHOULD omit Requires(pre,post): desktop-file-utils per http://fedoraproject.org/wiki/Packaging/ScriptletSnippets it is no longer required (FC-5+) _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review