https://bugzilla.redhat.com/show_bug.cgi?id=837331 Jiri Popelka <jpopelka@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jiri Popelka <jpopelka@xxxxxxxxxx> --- (In reply to comment #3) > > [!]: MUST Buildroot is not present > > [!]: MUST Package has no %clean section with rm -rf %{buildroot} > > [!]: MUST Each %files section contains %defattr if rpm < 4.4 > > [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > > beginning of %install. > > I believe these are incorrect. It does have a Buildroot tag, does have a > %clean section, does have %defattr in the %files sections, and does remove > the buildroot first thing in %install. Yes and you don't have to have/do them, because rpm takes care of it, so you can safely remove them. See my links to guidelines. But these are more a SHOULD then MUST (certainly it's not a blocker) so I think this package is APPROVED ! -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review