https://bugzilla.redhat.com/show_bug.cgi?id=837331 --- Comment #3 from David Woodhouse <dwmw2@xxxxxxxxxxxxx> --- (In reply to comment #2) > [!]: MUST All build dependencies are listed in BuildRequires, except for any > that are listed in the exceptions section of Packaging Guidelines. > > Missing: > BuildRequires: texinfo-tex > BuildRequires: texlive-dvips > BuildRequires: ghostscript Added; thanks. > [!]: MUST Buildroot is not present > [!]: MUST Package has no %clean section with rm -rf %{buildroot} > [!]: MUST Each %files section contains %defattr if rpm < 4.4 > [!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. I believe these are incorrect. It does have a Buildroot tag, does have a %clean section, does have %defattr in the %files sections, and does remove the buildroot first thing in %install. > [!]: SHOULD Reviewer should test that the package builds in mock. http://koji.fedoraproject.org/koji/taskinfo?taskID=4218564 > [!]: SHOULD Scriptlets must be sane, if used. > > Check https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo > > I'd replace > Requires(post): /sbin/install-info > Requires(preun): /sbin/install-info > with > Requires(post): info > Requires(preun): info > > and also the '.gz' seems to be redundant in %preun All fixed, thanks. Spec URL: http://david.woodhou.se/nettle.spec SRPM URL: http://david.woodhou.se/nettle-2.4-2.fc15.spec -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review