https://bugzilla.redhat.com/show_bug.cgi?id=837008 Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs? --- Comment #6 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> --- Thank you for the review! (In reply to comment #5) > * Forgotten TODO? > - Your spec file contains "# TODO: move the extensions". Seems to be some > relict? > Yep, I forgot it there. I will remove it before importing into dist-git. > * Disabled test suite > - Sad to see test suite disabled. Have you tried to confirm with upstream > that > root privileges are really needed?(In reply to comment #3) > The tests directly communicate with libvirt, for which you always needs to be superuser. Moreover, there are some system files modified in /etc. Without it, tests would have no meaning, everything would need to be mocked. > These comments are just minor nits. I see no other issues => APPROVED New Package SCM Request ======================= Package Name: rubygem-ruby-libvirt Short Description: Ruby bindings for LIBVIRT Owners: bkabrda Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review