[Bug 837008] Review Request: rubygem-ruby-libvirt - Ruby bindings for LIBVIRT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=837008

Vít Ondruch <vondruch@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #5 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Forgotten TODO?
  - Your spec file contains "# TODO: move the extensions". Seems to be some
    relict?

* Disabled test suite
  - Sad to see test suite disabled. Have you tried to confirm with upstream
that
    root privileges are really needed?(In reply to comment #3)

These comments are just minor nits. I see no other issues => APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]