[Bug 734248] Review Request: apf - Adventure PHP Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=734248

Jason Tibbitts <tibbs@xxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tibbs@xxxxxxxxxxx

--- Comment #3 from Jason Tibbitts <tibbs@xxxxxxxxxxx> ---
I'm just looking through some of the older NEEDSPONSOR tickets.

First point: one source package per review ticket, please.  If one
package/ticket depends on another, you indicate that via the Depends On: and
Blocks: fields.  Nobody will even start reviewing a ticket that doesn't meet
basic rules like that, which may account for the reason nobody has looked at it
until now.

Looking at just the apf package, the spec is a bit messy and has some
definitely forbidden things (conflicting macro usage, output during scriptlets)
and a few things that can be cleaned up (unnecessary buildroot stuff), but
nothing that can't be easily fixed.

Are you still interested in submitting these packages?  PHP isn't really my
strong suit and so I may attempt to get someone more familiar with the language
involved, but only if you still wish to submit this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]