https://bugzilla.redhat.com/show_bug.cgi?id=817271 --- Comment #18 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to comment #17) > (In reply to comment #16) > > Ok, a couple of nit-picks: > > > > 1. The source tag could use the %name and %version tags a little more: > > Source0: > > http://nightly.openerp.com/6.1/nightly/src/openerp-%{version}%{oe_rel}.tar.gz > > could be: > > Source0: > > http://nightly.openerp.com/%{version}/nightly/src/%{name}- > > %{version}%{oe_rel}.tar.gz > > > > unless the 6.1 doesn't get the patch level version number when/if it occurs. > I certainly could, and I will if you insist. However, using openerp instead > of name is on purpose and as I understand it according to the guidelines. > The macro section explicitly says that using macros (besides paths) is a > question of personal preferences, and I prefer writing the name "in clear". Nah, just something I've seen recommended. > Updating in place, same links, no release bumb (which actually is OK, > promise :) ) Hmm... Once bitten twice shy for me. I was chastised for doing just that early in my packaging career :) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review