https://bugzilla.redhat.com/show_bug.cgi?id=836014 --- Comment #3 from Julian Leyh <julian@xxxxxxx> --- (In reply to comment #2) Thanks for your nice review! Helps me a lot. > The debuginfo subpackage from Koji does have source files. I'm not sure what > went wrong with yours, but I've seen similar problems before. Are there any > symbolic links or bind mounts involved in the path to your rpmbuild > directory? yeah.. I have put the rpmbuild directory on a different location and symlinked it from $HOME. I will try out without symlink. > Here's what I have found in the package: > > · Instead of pointing to the AWS page that doesn't describe Templates > Parser, I suggest pointing to the documentation: > http://docs.adacore.com/aws-docs/templates_parser.html Okay. > · The tarball shrinks by 93% if you add --exclude-vcs to the tar command. I didn't know this option, thanks! > · Please build and package the documentation. Add "BuildRequires: > texinfo-tex", and "make doc" under %build. (Don't use _smp_mflags here, > because that causes docs/makefile to break.) Should the documentation go into a separate subpackage? %name-docs? > · Don't include the license field in subpackages unless it differs from the > base package. Okay. > · _GNAT_project_dir must be used. Pass "I_GPR=%{_GNAT_project_dir} > I_TGP=%{_GNAT_project_dir}/templates_parser" to make install. I left this out, because it was the same. But I do see the point, it might be somewhere else. Will change. > · The link named %{_libdir}/lib%{name}.so.%{version} doesn't help with > anything. Nothing will be looking for that filename because the library has > no soname, so the library won't be found at run time unless a runpath is > used. Here's a patch to add a soname: > http://lists.forge.open-do.org/pipermail/aws-patches/2012-June/000038.html Didn't really know if soname is necessary or not. In #fedora-devel nobody could give me a definite answer. About the patch you mention: if I understand correctly, it makes the library file "lib%{name}-%{version}.so", the version before the ".so". Should I change it like that? > · ldconfig must be called. Add the following to the spec file: > > %post -p /sbin/ldconfig > > %postun -p /sbin/ldconfig Yeah, forgot those.. This is my first library package, will add them. > · Wouldn't it be nice to also package templates2ada and templatespp? I > suggest putting them in a subpackage named templates_parser-tools with the > group field set to "Applications/Text". > > See also these patches: > http://lists.forge.open-do.org/pipermail/aws-patches/2012-June/000036.html > http://lists.forge.open-do.org/pipermail/aws-patches/2012-June/000037.html Thanks, I will add the tools subpackage. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review