https://bugzilla.redhat.com/show_bug.cgi?id=836014 Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn@xxxxxxxxxxxxxxxxxxxx --- Comment #2 from Björn Persson <bjorn@xxxxxxxxxxxxxxxxxxxx> --- (In reply to comment #0) > how can i fix the error for debuginfo subpackage? The debuginfo subpackage from Koji does have source files. I'm not sure what went wrong with yours, but I've seen similar problems before. Are there any symbolic links or bind mounts involved in the path to your rpmbuild directory? > Another question: Should GMGPL be added to the accepted licenses? It > basically is a GPLv2+ with linking exception. Or is "GPLv2+ with exceptions" > good enough? I think "GPLv2+ with exceptions" is good, but if you want a more authoritative answer you can ask on the legal mailing list, legal@xxxxxxxxxxxxxxxxxxxxxxx. Here's what I have found in the package: · Instead of pointing to the AWS page that doesn't describe Templates Parser, I suggest pointing to the documentation: http://docs.adacore.com/aws-docs/templates_parser.html · The tarball shrinks by 93% if you add --exclude-vcs to the tar command. · Please build and package the documentation. Add "BuildRequires: texinfo-tex", and "make doc" under %build. (Don't use _smp_mflags here, because that causes docs/makefile to break.) · Don't include the license field in subpackages unless it differs from the base package. · _GNAT_project_dir must be used. Pass "I_GPR=%{_GNAT_project_dir} I_TGP=%{_GNAT_project_dir}/templates_parser" to make install. · The link named %{_libdir}/lib%{name}.so.%{version} doesn't help with anything. Nothing will be looking for that filename because the library has no soname, so the library won't be found at run time unless a runpath is used. Here's a patch to add a soname: http://lists.forge.open-do.org/pipermail/aws-patches/2012-June/000038.html · ldconfig must be called. Add the following to the spec file: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig · Wouldn't it be nice to also package templates2ada and templatespp? I suggest putting them in a subpackage named templates_parser-tools with the group field set to "Applications/Text". See also these patches: http://lists.forge.open-do.org/pipermail/aws-patches/2012-June/000036.html http://lists.forge.open-do.org/pipermail/aws-patches/2012-June/000037.html -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review