https://bugzilla.redhat.com/show_bug.cgi?id=835432 --- Comment #17 from Richard Shaw <hobbes1069@xxxxxxxxx> --- (In reply to comment #16) > some drive by comments: > > - imho, there's no need for obsoletes, there's no version to obsolete. I did some searching and it doesn't exist in Fedora but it does on EL5. Perhaps it should be conditionalized if he intends to support EPEL? > - buildrequires: python-devel should be python2-devel, or something like: > BuildRequires: python2-devel > %if 0%{?with_python3} > BuildRequires: python3-devel > %endif # if with_python3 Yup, this will need to be fixed. I find it interesting though that the python template in rpmdev-newspec uses just python-devel. (In reply to comment #15) > There's a new specfile and RPM uploaded to the same links. > > Updates: > - Install a pkg-config PyCXX.pc file > - Own /usr/share/python2.7/ I'm concerned about this one. I'm not sure anything but python should own a directly like that. Perhaps /usr/src was a good idea? > This takes care of all the issues I'm aware of. Anyone up for a formal > review? Wish I could, we still need to find you a sponsor. If you have time I'm sure one of the links from comment 3 will tell you to do informal review on other review requests. This would probably be the fastest route. If you can do a few and come back here and reference them that would help. Also, an alternative (or in addition to) might be to package something off the wish list that someone really wants. In fact, I wonder if it would be a good idea to write to the devel list and mention you need sponsoring and are willing to package something a sponsor needs... -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review