https://bugzilla.redhat.com/show_bug.cgi?id=835432 --- Comment #16 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> --- some drive by comments: - imho, there's no need for obsoletes, there's no version to obsolete. - buildrequires: python-devel should be python2-devel, or something like: BuildRequires: python2-devel %if 0%{?with_python3} BuildRequires: python3-devel %endif # if with_python3 https://fedoraproject.org/wiki/Packaging:Python#BuildRequires - you should link your patches to tickets upstream, esp. you should put a comment to those patches, what they do or why they are required. - your package python-%{modname} doesn't have %files:, it contains [mrunge@mrungexp result]$ rpm -qlp python-pycxx-6.2.4-0.fc18.src.rpm pycxx-6.2.4.tar.gz python-pycxx-6.2.4-change-include-paths.patch python-pycxx-6.2.4-fix-indentation.patch python-pycxx.spec - there's python3 support built in, so you should package that too. - compiler flags are not required for noarch packages, so either noarch, or compiler flags... -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review