https://bugzilla.redhat.com/show_bug.cgi?id=834239 Orcan Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flags| |fedora-review? --- Comment #5 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> --- Jorn, it is good practice in general - to take a look at the build log and the rpmlint output of all resulting packages (RPMs and the SRPM) for warning and error messages, - to build the package in mock, at least for rawhide, but better for rawhide and stable release(s) (If you do this you can rpmlint the result/ directory directly to evaluate all the resulting rpms inside. Two birds with one stone) before you resubmit it during the review. Now, * The fitting macro is %{_libdir}. You can find the standard macros in file /usr/lib/rpm/macros, and additional macro definition files inside /etc/rpm/ * rpmlint says (duplicates removed): monobristol.src: W: spelling-error %description -l en_US subtractive -> subtraction, subtract, attractive monobristol.x86_64: E: no-binary monobristol.x86_64: W: only-non-binary-in-usr-lib monobristol.x86_64: W: no-manual-page-for-binary monobristol Let us ignore the above monobristol.src: W: spelling-error Summary(en_US) bristol -> Bristol monobristol.src: W: spelling-error %description -l en_US synthesisers -> synthesizers, synthesizer, synthesis Please correct the above. Americanos use "synthesizers" monobristol.x86_64: E: non-executable-script /usr/share/applications/monoBristol.desktop 0644L /usr/bin/env This should be fixed. I don't know why they ship a .desktop file with a shebang. Unless this is some very new .desktop file specification, please remove the shebang in your patch. I guess you will need to re-email (sorry). * You are installing a .desktop file, which has a "Icons" tag. This means we better ship an icon with this package, so we don't end up with a naked menu entry. A good candidate is the monobristol.png file in the top source directory. Since this icon is 48x48 we shall install it at %{_datadir}/icons/hicolor/48x48/apps/ ! BuildRequires: mono-devel monodevelop These don't seem necessary. ! You don't need the line mkdir -p %{buildroot}%{_datadir}/applications it doesn't do any harm though, not a blocker. ? How do I use this application? None of the synths seem to open here. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review