[Bug 833573] Review Request: nettle - Low level crytopgraphic library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=833573

--- Comment #6 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
Just a brief look:


* https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming

As a precedent, Debian and openSUSE called it libnettle.


* https://fedoraproject.org/wiki/Packaging:ReviewGuidelines

| MUST: rpmlint must be run on the source rpm and all binary rpms
| the build produces. The output should be posted in the review.[1] 

That doesn't imply it's only the reviewer who must do this. rpmlint is also a
tool for packagers.


> Version: 2.5
> Release: 0.1pre%{?dist}

https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

A little bit pedantic, but Fedora adds another dot after the X.Y number:
Release: 0.1.pre%{?dist}


> License: LGPLv2.1+

https://fedoraproject.org/wiki/Licensing#Good_Licenses


> %package tools
> Group: System Environment/Libraries

As tools are not libraries, the package could fit into groups "System
Environment/Base" or "Development/Tools". The package description doesn't
expand on what these utility programs do, however.


> %package devel
> Summary: Development files for libnettle
> License: GPLv2+ and LGPLv2.1+

This will require a closer look. Why does the licensing here differ from the
base library packages?


> Requires: %{name} = %{version}-%{release}
> Requires: libhogweed = %{version}-%{release}

https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package


> %preun -p /sbin/ldconfig
> 
> %preun -n libhogweed -p /sbin/ldconfig

%postun would be the correct place to execute this.


> %files tools
> %doc COPYING.LIB

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing


> testsuite

Please investigate whether this is suitable for running "make check" in the
%check section of the spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]