https://bugzilla.redhat.com/show_bug.cgi?id=833462 --- Comment #6 from Michael Schwendt <mschwendt@xxxxxxxxx> --- https://fedoraproject.org/wiki/Packaging:ReviewGuidelines | MUST: rpmlint must be run on the source rpm and all binary rpms | the build produces. The output should be posted in the review.[1] That doesn't imply it's only the reviewer who must do this. rpmlint is also a tool for packagers. > Summary: A Library providing simplified C and Python API to libsolv Summaries without leading articles are more readable in package tools and Anaconda. > Group: Development/Libraries "System Environment/Libraries" is the primary group for shared lib packages. > Source0: hawkey-%{gitrev}.tar.xz https://fedoraproject.org/wiki/Packaging:SourceURL#Using_Revision_Control > BuildRequires: python2 python2-devel This build requirement doesn't match the run-time requirement further below, which makes it unsafe and not precise enough: | %package -n python-hawkey | Requires: python Plus, https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires also applies here, and a comment in the spec file would be good. > Requires: libsolv >= %{libsolv_version} https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires Also, consider using %{?_isa} in such explicit dependencies, too. > %description > A Library providing simplified C and Python API to libsolv Here, creating full sentences including punctuation would be the way to go. > %files > %doc COPYING README.md > %files devel > %doc COPYING https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing > %_includedir/hawkey When including entire directory trees like this, it's typically more readable to add a trailing slash and make clear that it's not a single file to be included only: %_includedir/hawkey/ -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review