[Bug 806040] Review Request: pyproj - a python module that performs cartographic transformations and geodetic computations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=806040

--- Comment #14 from jdekloe <kloe0040@xxxxxxxxx> ---
New spec and srpm files are here:

Spec URL: http://jdekloe.nl/Fedora/pyproj.spec
SRPM URL: http://jdekloe.nl/Fedora/pyproj-1.9.2-4.r298.fc16.src.rpm

The dot has been added as suggested, and I changed the version to 1.9.2 as
mentioned in the setup file.

numpy is listed as a build requirement, needed by and used in setup-proj.py.
It's not used in setup.py. It's also not clear to me why it is needed during
the build, since it is not used in the pyx file. I'll ask the upstream
developer about this.

As you say numpy is mentioned and commented in the __init__.py file. The module
may return numpy.ndarray's as result (if it gets them as input), but this is
optional and standard python lists, tuples or scalars as input work equally
well. Therefore I guess during runtime numpy is optional and not really
required.

The chmod to correct the permission, the "%{_usr}/" macro and its export have
been added.

As for testing. After some experimenting the mock tool indeed is suitable for
this. It does need manual addition of the proj and proj-nad packages before the
testing actually works.
With this method I could verify that both the python and the python3 package
can be imported and used as intended.

Thanks to this testing I found that I needed to add proj-nad as requirement.
That one contains datafiles needed during use of the module. If not present the
module will not load.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]