[Bug 806040] Review Request: pyproj - a python module that performs cartographic transformations and geodetic computations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=806040

--- Comment #13 from Volker Fröhlich <volker27@xxxxxx> ---
Please add a period between "3" and "%{svn}. By doing so, it also matches what
you have in the changelog.

I noticed that setup.py states version 1.9.2. I assume this does not cause any
harm.

Concerning numpy: While it is advertised in the description, it actually seems
to be commented out in the actual code. I wonder why is that.

The permissions are 775 because CCACHE_UMASK is set to 002 in mock for some
reason. Please correct the permissions with a chmod in the install section.

Python 3 looks fine.

I suggest to use "%{_usr}/" instead of plain "/usr/" for PROJ_DIR. You forgot
to export the variable, therefore it doesn't do anything right now.

Ad testing: I could think of the following way: Install the finished package
into the existing Mock chroot and then shell into it. I think that should do
it.

Please see http://fedoraproject.org/wiki/Projects/Mock for details.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]