[Bug 832635] Review Request: pencil - A sketching and GUI prototyping tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=832635

--- Comment #3 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
(In reply to comment #2)
> (In reply to comment #1)
> > - The .desktop file is not handled correct,
> > https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
> 
> I have read these instructions more. Could you tell me more detailed what's
> wrong with it?

The .desktop file is not installed.

> > - http://evoluspencil.googlecode.com/files/pencil-2.0.tar.gz gives an 404
> > error
> 
> Actually, the upstream developer did not release the whole software source
> as a tar file like this. He sent me this SVN link:
> http://evoluspencil.googlecode.com/svn/branches/pencil-2.0
> I got sources, change some file/folder locations then build myself (of
> course, I notified my changes to him)

It's not going to fly...downloading source code, modify it locally, and then
use that code is not the way it works. When you are using a scm
checkout/snapshot, notes about the details should be mentioned in the spec file
and the numbering should reflect it too. I suggest that you try to convince
upstream to make a proper release.

btw, rpmlint says:
[fab@laptop11 noarch]$ rpmlint pencil-2.0-1.fc17.noarch.rpm 
pencil.noarch: E: zero-length
/usr/share/pencil/content/pencil/templates/ODT/default.ODT/Configurations2/accelerator/current.xml
pencil.noarch: E: zero-length /usr/share/pencil/skin/classic/pencil.css
pencil.noarch: E: zero-length
/usr/share/pencil/content/pencil/templates/HTML/default.HTML/Resources/SampleStyle.css
pencil.noarch: W: no-manual-page-for-binary pencil
1 packages and 0 specfiles checked; 3 errors, 1 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]