https://bugzilla.redhat.com/show_bug.cgi?id=828879 --- Comment #8 from Eric Sandeen <esandeen@xxxxxxxxxx> --- All this is OK (the MUSTS): rpmlint is amazingly quiet ;) package naming is fine specfile name matches AFAICT, it follows python packaging rules, but I am no expert there! License (GPLv2+) is acceptable for Fedora. License matches license statements in source COPYING file contains license and is in %doc Specfile is legible and in American e=English Source matches upstream Upstream source URL is fine package built fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=4180107 RPM does own the two dirs it creates File perms seem fine Macros are consistently used in the specfile Package contains permissible content (code) Doc files work properly with --excludedocs; there is no %doc directive but %{_docdir} seems to imply that. No static or devel libraries, so no issues there. Questions / suggestions: For runtime requires, I wonder about the fs utilities it invokes. If it handles it gracefully when they are missing, probably no need for a runtime requirement, but if not, perhaps you should require those packages at least for now? I'll try to grep through & see what all might get executed. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review