https://bugzilla.redhat.com/show_bug.cgi?id=830863 Jakub Jelinek <jakub@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(jakub@xxxxxxxxxx) | --- Comment #3 from Jakub Jelinek <jakub@xxxxxxxxxx> --- (In reply to comment #2) > dwz.spec: W: invalid-url Source0: dwz-0.2.tar.bz2 > - Fix: There must be public downloadable URL for it. I thought it must be there only if instructions aren't given how to generate it from the RCS (the comment right above Source0 line). > E: incorrect-fsf-address hashtab.c > E: incorrect-fsf-address dwz.c > E: incorrect-fsf-address hashtab.h > - Fix. > W: manual-page-warning dwz.1.gz 83: warning: macro `Nothing' not defined > - Fix: > -into > -.B FILE > -\. Nothing is written if > +into \fBFILE\fR. Nothing is written if > W: manual-page-warning dwz.1.gz 132: warning: macro `If' not defined > - Fix: > -and in the last file to > -.I ../../.dwz/foobar-1.2.debug > -\. If e.g. bin/foo.debug and bin/foo2.debug were hardlinked > +and in the last file to \fI../../.dwz/foobar-1.2.debug\fR. > +If e.g. bin/foo.debug and bin/foo2.debug were hardlinked Will fix. Thanks. > make in %build > - It should use: %{?_smp_mflags} Not worth it, but can certainly add it ;) > BuildRequires: elfutils-libelf-devel > - It should use: %{?_isa} > As I expect it will go also for EPEL-5 it will need Buildroot, > rm -rf $RPM_BUILD_ROOT and maybe some other things. Not an issue here. I'll add it so that it can be shared with scl. > BTW it prints: > dwz.c: In function 'write_dso': > dwz.c:10172:10: warning: ignoring return value of 'fchown', declared with > attribute warn_unused_result [-Wunused-result] That ignoring is intentional, guess I can add some hack to shut up the warning. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review