https://bugzilla.redhat.com/show_bug.cgi?id=830992 --- Comment #4 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- This isn't a review, just some comments. I find spec files much easier to read if the fields are lined up, like this example: http://oirase.annexia.org/reviews/whenjobs/whenjobs.spec Modern spec files *don't* need: * BuildRoot * %clean * rm -rf buildroot * defattr All of the above can be removed. Is the license LGPLv2 or LGPLv2+? Instead of ./configure + options, use %configure macro. Instead of CFLAGS=..., use 'make %{_smp_mflags}' -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review