https://bugzilla.redhat.com/show_bug.cgi?id=825496 --- Comment #3 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> --- Before doing a full review, you should: -remove the bundled egg-info in %prep rm -rf django_staticfiles.egg-info - delete the first two lines from spec: %{!?python_sitelib: %define python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")} - buildrequires python-devel should read python2-devel - buildrequires python-setuptools-devel should read python-setuptools - personally, I think listing each requirement in a separate line is more readable - python-django is not a build requirement - when making a version 0.3.2-2 you shouldn't obsolete < 0.3.2-3 (you would obsolete yourself) - files should contain %{python_sitelib}/staticfiles %{python_sitelib}/django_staticfiles-%{version}-py?.?.egg-info -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review