https://bugzilla.redhat.com/show_bug.cgi?id=823056 --- Comment #7 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> --- (In reply to comment #5) > This package seems broken. > > Until version 2.0.14 all ".res" file were installed as "php" > Since version 2.0.15 they are installed as "doc" > > In code (Symfony/Component/Locale/Locale.php) the have > $bundle = \ResourceBundle::create($locale, __DIR__.'/Resources/data/region'); > > So, file will not be found. > > This, of course, need to be reported upstream and, at least fixed in > package.xml for the review Since these fixes upstream will require a new release (probably 2.0.16), may I just fix the package.xml in the spec file? > All this "locale" %files should be tag with "%lang(xx)" I will work on this. > ---- > Out of the scope of this review: > > I personally think this files should be installed as "data" but this will > requires some changes in the code () > > For example (taken from Date_Holidays) > $data_dir = "@DATA-DIR@"; > if ($data_dir == '@'.'DATA-DIR'.'@') { > // run from source dir > $data_dir = dirname(__FILE__)."xxxxxxx"; > } else { > // run from install dir > $data_dir .= "xxxxxx"; > } > > And, in package.xml, when needed > <tasks:replace from="@DATA-DIR@" to="data_dir" type="pear-config" /> I will work with upstream on this. Several packages could use this approach. I'm pretty sure this approach would break their unit tests though, but I will work with them. Speaking of unit tests, upstream does not include their unit tests in their PEAR packages (only in their SCM repo). Is that common? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review