[Bug 823046] Review Request: php-symfony2-DependencyInjection - Symfony2 DependencyInjection Component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=823046

--- Comment #9 from Shawn Iwinski <shawn.iwinski@xxxxxxxxx> ---
(In reply to comment #8)
> So for late error detection
> 
> DependencyInjection/Loader/schema/dic/services/services-1.0.xsd should be
> installed as role="php", not as role="doc" as this path is referred in the
> code
> 
> In DependencyInjection/Loader/XmlFileLoader.php
> 
>    $schemaLocations = array('http://symfony.com/schema/dic/services' 
>    => str_replace('\\', '/',
> __DIR__.'/schema/dic/services/services-1.0.xsd'));
> 
> 
> Like for "Locale" this should be reported upstream, and role="data" is
> probably a better solution.

Thanks for finding this Remi.  I will make sure to fix the issue before
proceeding.

I will get upstream to fix the package.xml role for the *.xsd file.  It will
take a code change to allow for role="data", but I will work with upstream to
fix the issue.  If role="data" will take some time to implement, is it fine to
revert to role="php" for now and plan on role="data" for a future enhancement?

I looked through all the other php-symfony2-* packages and it appears this same
error exists in version 2.0.15 for the Routing, Translation, and Validator
packages as well.  I will update those reviews with this information and work
with upstream to fix.

Since these fixes upstream will require a new release (probably 2.0.16), may I
just fix the package.xml in the spec file?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]