https://bugzilla.redhat.com/show_bug.cgi?id=819953 --- Comment #9 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- I appreciate the feedback, but please focus on review-blockers only first. In particular, I need feedback on (stuff I'm not sure are worth worrying too much about right now...): - macros: please use consistently the name macro how so exactly? - if you add lightdm user on installation, you should remove him on uninstallation ? does it say that anywhere in our packaging guidelines? (i'm pretty sure it doesn't, and if it does, we should probably get them changed) :) - I think you should split the devel package, but not sure if this is required ditto, as above. it may or may not make sense to do this at some point, but it's largely a cosmetic issue. the others I'll get to work on, thanks. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review