https://bugzilla.redhat.com/show_bug.cgi?id=819953 --- Comment #8 from Gregor Tätzner <gregor@xxxxxxxxxx> --- pre review: - licence GPLv2 is not sufficient. Most of the files are GPLv3+ with exception off: /liblightdm-gobject and /liblightdm-qt: LGPLv3+ /tests: not specified - macros: please use consistently the name macro - patch numbering seems odd - if you install lightdm sub-packages isolated, COPYING file does not get pulled - add CHANGELOG to %doc - if you add lightdm user on installation, you should remove him on uninstallation again (%preun I suppose) - I think you should split the devel package, but not sure if this is required - lightdm.x86_64: W: log-files-without-logrotate /var/log/lightdm - mark as config: %{_sysconfdir}/dbus-1/system.d/org.freedesktop.DisplayManager.conf rpmlint lightdm: lightdm.x86_64: W: only-non-binary-in-usr-lib lightdm.x86_64: W: non-standard-uid /var/cache/lightdm lightdm lightdm.x86_64: W: non-standard-gid /var/cache/lightdm lightdm lightdm.x86_64: E: non-standard-dir-perm /var/cache/lightdm 01775L lightdm.x86_64: W: non-standard-uid /var/lib/lightdm lightdm lightdm.x86_64: W: non-standard-gid /var/lib/lightdm lightdm lightdm.x86_64: E: non-standard-dir-perm /var/lib/lightdm 01770L lightdm.x86_64: W: non-standard-uid /var/log/lightdm lightdm lightdm.x86_64: W: non-standard-gid /var/log/lightdm lightdm lightdm.x86_64: E: non-standard-dir-perm /var/log/lightdm 01770L rpmlint lightdm-devel: lightdm-devel.x86_64: W: no-dependency-on lightdm/lightdm-libs/liblightdm Can we ignore these? -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review