[Bug 720857] Review Request: datalog - A Lightweight Deductive Database using Datalog

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=720857

--- Comment #42 from John D. Ramsdell <ramsdell@xxxxxxxxx> ---
(In reply to comment #41)

Thank you Michel for your help.

I updated the spec as suggested except the make check target doesn't do real
test so I did not define the %check section.

Spec URL: http://www.ccs.neu.edu/home/ramsdell/tools/datalog/datalog.spec
SRPM URL: http://downloads.sourceforge.net/datalog/datalog-2.2-3.fc16.src.rpm

$ diff -ur a b
diff -ur a/datalog.spec b/datalog.spec
--- a/datalog.spec    2012-06-05 07:51:00.689398272 -0400
+++ b/datalog.spec    2012-06-05 07:51:07.633588896 -0400
@@ -3,7 +3,7 @@

 Name:        datalog
 Version:    2.2
-Release:    2%{?dist}
+Release:    3%{?dist}

 Source0:    http://downloads.sourceforge.net/datalog/%{name}-%{version}.tar.gz

@@ -12,7 +12,9 @@

 Summary:    A Lightweight Deductive Database using Datalog
 License:    LGPLv2+
+%if 0%{?rhel}
 Group:        Applications/Databases
+%endif

 BuildRequires:    texinfo, lua-devel < 5.3

@@ -32,8 +34,9 @@

 %package devel 
 Summary: Datalog header file and library
-License: LGPLv2+
+%if 0%{?rhel}
 Group: Development/Libraries
+%endif
 Requires: datalog = %{version}

 %description devel 
@@ -48,7 +51,6 @@
 make %{?_smp_mflags}

 %install
-rm -rf %{buildroot}
 make DESTDIR=%{buildroot} install
 mkdir -p %{buildroot}%{luapkgdir}
 install -m 644 %{name}.lua %{buildroot}%{luapkgdir}
@@ -88,6 +90,11 @@
 %{_libdir}/lib%{name}.so

 %changelog
+* Tue Jun  5 2012 John D. Ramsdell <ramsdell@xxxxxxxxx> - 2.2-3
+- Removed rm of build root in %%install
+- Group field defined only for RHEL
+- Removed license field in subpackage devel
+
 * Fri May 25 2012 John D. Ramsdell <ramsdell@xxxxxxxxx> - 2.2-2
 - Changed %%define to %%global

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]