https://bugzilla.redhat.com/show_bug.cgi?id=720857 --- Comment #41 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> --- Hi John, Some notes: - BuildRoot definition is only required if you're targeting RHEL 5. If you do, I'd suggest making it conditional: %if 0%{?el5} BuildRoot: ... %endif Likewise, unless you're on RHEL 5, you don't need to clean it at the beginning of %install - Subpackages inherit the fields of the main package unless overridden. So there's no need to re-specify the license as they're identical - Group declaration is only required in RHEL 5, but RHEL 6's rpmlint still warns if it's not defined. It's no longer used by Fedora, so you can, if you want, make them conditional too (but with %if 0%{?rhel} instead -- or %if 0%{?rhel} < 7) - Looks like your Makefile has a 'make check' target -- if there are real tests for it, you might want to define a '%check' section: %check make check -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review