[Bug 825854] Review Request: zita-alsa-pcmi - alsa pcm libraries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=825854

--- Comment #3 from Michael Schwendt <mschwendt@xxxxxxxxx> ---
There's an eyebrow-rasier in the spec file:

> sed -i -e 's|-O2 -Wall|%{optflags} -I../libs|' \
>     -e 's|ldconfig||' libs/Makefile
> # We don't want to run ldconfig in the build environment. 

Why?
And later:

> # install missing symlink (was giving no-ldconfig-symlink rpmlint errors)
> ln -sf %{_libdir}/lib%{name}.so.%{version} %{buildroot}%{_libdir}/lib%{name}.so.0

Running ldconfig would create that missing symlink. You could even explicitly
run

   ldconfig -n %{buildroot}%{_libdir}

to create the needed symlink instead of creating it manually with a hardcoded
version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]