https://bugzilla.redhat.com/show_bug.cgi?id=825418 --- Comment #2 from Peter Lemenkov <lemenkov@xxxxxxxxx> --- * First of all it fails to build (fails to pass the tests) until I removed all "time" invocations in the Makefile with the following line appended to the %prep section: sed -i -e "s,time ,,g" Makefile After that it builds just fine. * Consider removing *.bat files entirely. * I did a dependency checking with my (yet to be published) API checker and found that there are some missing dependencies. At least you must explicitly add Requires: erlang-inets My API checker shows that elixir's beam-files are also exporting functions from the following modules: Requires: erlang-compiler Requires: erlang-kernel Requires: erlang-stdlib Requires: erlang-syntax_tools but these ones are safe to omit since they're in a default dependency chain from erlang-erts. Feel free either to add them or not. * This package requires erlang-erts >= R15B - please fix your Requires directive. Just FYI - I plan to upgrade Erlang in F-16 and in EL6 up to R15B very soon. F-17 and F-18 already has R15B. Actually the only missing function in R14B is "file:read_file_info/2" and I believe the package could be fixed to work with R14B but I wouldn't hold my breath waiting for someone who is willing to fix that in the nearest future. Anyway since we will see a R15B build for EL6 and F-16 soon then this shouldn't even bother you. * Just FYI - The package won't work with R12B so no luck for EL5 users. Error:erlang(erlang:atom_to_binary/2) Error:erlang(erlang:binary_to_atom/2) Error:erlang(erlang:port_command/3) Error:erlang(erl_scan:token_info/2) Error:erlang(file:read_file_info/2) Error:erlang(io_lib:write_unicode_string/1) Error:erlang(lists:keyfind/3) Error:erlang(unicode:characters_to_binary/1) Error:erlang(unicode:characters_to_list/1) Some of these can be fixed easily, some cannot. My advice in case you have plans for EL5 builds (I hope you don't have them yet) is just to forget about that. * You didn't package include/elixir.hrl Whenever package it or not is entirely depends on the typical workflow which involves elixir - if you will use it from within other erlang packages then it *might* (I'm not sure) be useful, otherwise it may not. If I were you I'd rather package it - I see that files files from tests/erlang/ have "-include("elixir.hrl") directive so one could use it this way. Otherwise it looks quite good. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review