https://bugzilla.redhat.com/show_bug.cgi?id=815624 --- Comment #12 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> --- (In reply to comment #11) > [!]: MUST Each %files section contains %defattr if rpm < 4.4 > Note: defattr(....) present in %files section. This is OK if packaging > for EPEL5. Otherwise not needed > > If you're building also for EPEL-5 please add %buildroot, %clean section and > remove file as the beginning of the %install section; otherwise please > remove %defattr in the %files section. I removed the defattr as it is redundant. > [!]: MUST If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package is included in %doc. > > The "COPYING" file is not included in the generated package. Added it to the package as well as other documentation files. > [!]: MUST License field in the package spec file matches the actual license. > > The "COPYING" file contains multiple licenses, are you sure a simple "MIT" > license is enough? The licenses are MIT or BSD-style without clauses. I also added GPLv2+ because of the int64 patch actually adapts code from libgcc. > [!]: SHOULD %check is present and all tests pass. > > A "make check" seems to be implemented in the makefile. It is a fallback that does nothing, but for the sake of review I added it :-) > [!]: SHOULD Packages should try to preserve timestamps of original installed > files. > > You can use this in the %install section: > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" Added it. > [!]: SHOULD Latest version is packaged. > > I see version 1.2.0 in the xorg repository. Sorry for that, I had basically just copied the Mandriva spec and made some minor adjustments to it. > rpmlint output is ok: > $ rpmlint *rpm > 3 packages and 0 specfiles checked; 0 errors, 0 warnings. > > > Please correct the above and you're good to go! Thanks. I will probably need to wait a bit until a problem in libXaw is corrected, otherwise, xedit will crash most times, well any time some code path involving selections is exercised. I made a RFE about it at https://bugzilla.redhat.com/show_bug.cgi?id=824198 and rebuilt Xaw locally, as I use xedit for pretty much any text editing :-) New package Spec URL: http://fedorapeople.org/~pcpa/xedit.spec SRPM URL: http://fedorapeople.org/~pcpa/xedit-1.2.0-1.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review