Comment # 11
from Simone Caronni
[!]: MUST Each %files section contains %defattr if rpm < 4.4
Note: defattr(....) present in %files section. This is OK if packaging
for EPEL5. Otherwise not needed
If you're building also for EPEL-5 please add %buildroot, %clean section and
remove file as the beginning of the %install section; otherwise please remove
%defattr in the %files section.
[!]: MUST If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
The "COPYING" file is not included in the generated package.
[!]: MUST License field in the package spec file matches the actual license.
The "COPYING" file contains multiple licenses, are you sure a simple "MIT"
license is enough?
[!]: SHOULD %check is present and all tests pass.
A "make check" seems to be implemented in the makefile.
[!]: SHOULD Packages should try to preserve timestamps of original installed
files.
You can use this in the %install section:
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
[!]: SHOULD Latest version is packaged.
I see version 1.2.0 in the xorg repository.
rpmlint output is ok:
$ rpmlint *rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please correct the above and you're good to go!
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review