| What | Removed | Added |
|---|---|---|
| Flags | fedora-review? | fedora-review+ |
Comment # 4
from Petr Pisar
Spec file changes:
--- perl-Module-Install-Repository.spec.old 2012-05-17 17:06:13.000000000
+0200
+++ perl-Module-Install-Repository.spec 2012-05-22 10:12:10.000000000 +0200
@@ -9,13 +9,17 @@
BuildArch: noarch
BuildRequires: perl >= 0:5.005
BuildRequires: perl(inc::Module::Install)
-# Build-time inc-ed:
-# XXX: We cannot remove ./inc because it build-requires this module
(bootstrap)
BuildRequires: perl(Module::Install::AuthorTests)
BuildRequires: perl(Module::Install::Base)
BuildRequires: perl(Module::Install::TestBase)
+# Tests
+BuildRequires: perl(File::Temp)
BuildRequires: perl(Path::Class)
BuildRequires: perl(Test::More)
+# Optional tests
+BuildRequires: perl(Test::Perl::Critic)
+BuildRequires: perl(Test::Spelling)
+BuildRequires: perl(Test::Pod) >= 1.00
Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
%description
@@ -25,6 +29,10 @@
%prep
%setup -q -n Module-Install-Repository-%{version}
+rm -r inc
+sed -i -e '/^inc\// d' MANIFEST
+sed -i -e '/^auto_set_repository/ d' Makefile.PL
+find -type f -exec chmod -x {} +
%build
%{__perl} Makefile.PL INSTALLDIRS=vendor
@@ -34,6 +42,7 @@
make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;
+find $RPM_BUILD_ROOT -type f -name .author -exec rm -f {} \;
%{_fixperms} $RPM_BUILD_ROOT/*
%check
> TODO: Build-require `perl(base)' (lib/Module/Install/Repository.pm:8).
Not reflected. Ok.
> TODO: Build-require `perl(File::Temp)' (t/01_find_repo.t:7).
+BuildRequires: perl(File::Temp)
Ok.
> FIX: Build-require all dependencies of inc/* (like `perl(threads::shared)' at
> inc/Test/Builder.pm:24) or unbundle modules that can be unbundled.
+rm -r inc
+sed -i -e '/^inc\// d' MANIFEST
+sed -i -e '/^auto_set_repository/ d' Makefile.PL
Ok.
TODO: The package does not build locally if some Critic plug-ins and wordlists
are installed because of failing optional tests:
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'inc', 'blib/lib', 'blib/arch')" t/*.t xt/*.t
t/00_compile.t .... ok
t/01_find_repo.t .. 1/2 cannot remove path when cwd is /tmp/xMrPg3p_CH for
/tmp/xMrPg3p_CH: at
/home/test/rpmbuild/BUILD/Module-Install-Repository-0.06/inc/File/Temp.pm line
901.
t/01_find_repo.t .. ok
xt/perlcritic.t ... 1/1
# Failed test 'Test::Perl::Critic for "lib/Module/Install/Repository.pm"'
# at /usr/share/perl5/vendor_perl/Test/Perl/Critic.pm line 110.
#
# Perl::Critic found these violations in "lib/Module/Install/Repository.pm":
# Three-argument form of open used at line 53, column 9. Three-argument open
is not available until perl 5.6. (Severity: 5)
# Looks like you failed 1 test of 1.
xt/perlcritic.t ... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
xt/pod.t .......... ok
xt/podspell.t ..... 1/1
# Failed test 'POD spelling for lib/Module/Install/Repository.pm'
# at /usr/share/perl5/vendor_perl/Test/Spelling.pm line 163.
# Errors:
# Matsuno
# Tokuhiro
# svn
# Looks like you failed 1 test of 1.
xt/podspell.t ..... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests
If you removed the inc/.author in %prep, you would not run xt/* tests and you
would not need to build-requires the optional dependencies (and prune the file
in %install; actually the file from inc/ does not get installed into
RPM_BUILD_ROOT.)
$ rpmlint perl-Module-Install-Repository.spec
../SRPMS/perl-Module-Install-Repository-0.06-1.fc18.src.rpm
../RPMS/noarch/perl-Module-Install-Repository-0.06-1.fc18.noarch.rpm
perl-Module-Install-Repository.src: W: spelling-error Summary(en_US) svn ->
sen, sin, son
perl-Module-Install-Repository.src: W: spelling-error Summary(en_US) svk ->
Sven
perl-Module-Install-Repository.noarch: W: spelling-error Summary(en_US) svn ->
sen, sin, son
perl-Module-Install-Repository.noarch: W: spelling-error Summary(en_US) svk ->
Sven
2 packages and 1 specfiles checked; 0 errors, 4 warnings.
TOD: Capitalize `svn' and `svk' in these are names of version control systems
like a Git. Current wording is not consistent (it mixes command names and tool
names).
Package build in F18 koji
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4093508). Ok.
Please consider fixing all `TODO' items before building this package.
Resolution: Package APPROVED.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review