Comment # 11
from Jan Vcelak
(In reply to comment #8) > [!]: MUST Changelog in prescribed format. > > I guess you added the epoch when you changed the release style to > pre-release. Since no actual package was published yet, we can and should > step back from that and just drop the epoch. Fixed. > [!]: MUST Package does not own files or directories owned by other packages. > > This package owns %{_datadir}/fatrat/lang, owned by fatrat Fixed. > [!]: MUST Sources used to build the package match the upstream source, as > provided in the spec URL. > /home/makerpm/758734/fatrat-subtitlesearch-1.2.0_beta1.tar.gz : > MD5SUM this package : ad8a24060826bcde1d85581e6844ea29 > MD5SUM upstream package : d41d8cd98f00b204e9800998ecf8427e This is a false positive. $ spectool -S fatrat-subtitlesearch.spec Source0: http://www.dolezel.info/download/data/fatrat-subtitlesearch/fatrat-subtitlesearch-1.2.0_beta1.tar.gz $ curl -s http://www.dolezel.info/download/data/fatrat-subtitlesearch/fatrat-subtitlesearch-1.2.0_beta1.tar.gz | md5sum - ad8a24060826bcde1d85581e6844ea29 - Something went wrong with your download probably. The file must have been emtpy. $ echo -n | md5sum d41d8cd98f00b204e9800998ecf8427e - > [!]: MUST Spec file is legible and written in American English. > > Please make it: "FatRat is a download manager" and "built" Fixed. > [!]: SHOULD Package functions as described. > > After starting fatrat-1.2.0-0.3.beta1.fc16.x86_64 , I see ... > "2012-04-10 18:57:17 - Loaded a plugin: libfatrat-subtitlesearch.so > 2012-04-10 18:57:17 - WARNING: the plugin is incompatible: > libfatrat-subtitlesearch.so" > ... on the log tab. I'm getting just a warning: dlopen "/usr/lib64/fatrat/plugins/libfatrat-subtitlesearch.so" WARNING! Version conflict. "libfatrat-subtitlesearch.so" is 1.1.3 but FatRat is 1.2.0_beta1 Anyway the plugin works fine, the version exported by the library is wrong. I do not think this is critical for this review. I will report this problem to the maintainer. > [!]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise > justified. > > Please inform the developer, that we want to be able to use a > system-wide qtsoap. They could either un-bundle it or change their build > system to allow for it without patching. I'm always writing comments directly to patch headers. And I know the developer in person, we already talked about it. It will be hopefully resolved upstream in future. > [!]: SHOULD SourceX / PatchY prefixed with %{name}. > Note: Patch100: fatrat-subtitlesearch-qtsoap.patch (fatrat- > subtitlesearch-qtsoap.patch) Fixed. > [!]: MUST The locales aren't handled properly yet: > Please see > http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files Fixed. Spec URL (updated): http://jvcelak.fedorapeople.org/review/fatrat-subtitlesearch/1.2.0-0.3.beta1/fatrat-subtitlesearch.spec SRPM URL (updated): http://jvcelak.fedorapeople.org/review/fatrat-subtitlesearch/fatrat-subtitlesearch-1.2.0-0.3.beta1.fc17.src.rpm
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review