| What | Removed | Added |
|---|---|---|
| CC | rc040203@freenet.de |
Comment # 4
from Ralf Corsepius
Some personal remarks:
- Shipping the *.asc sig seems pretty meaningless to me.
- I personally, would encourage you to use use %{?dist} in the %release tag.
Sure, it's not mandatory and not using it helps avoiding rebuilds, if a
package's contents doesn't change between Fedora/RHEL releases, however it also
makes packages vulnerable to changes in rpm and to the file system layout
between releases (A CentOS5's xxx-*.rpm is something entirely different than a
Fedora 18's xxx-*.rpm, even though it's NEVR are identical).
- I would recommend to use "install -m xxx" instead of "mkdir + cp" in
%install.
This helps to avoid bad surprizes related to ownership/permissions/umasks.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review