Comment # 2
from Adrian Alves
(In reply to comment #1) > As I am not sponsored, this isn't a formal review, but here are a couple of > things: > > -There's no source URL in the spec file, just "Source0: > %{name}-%{version}.tar.gz". You should point this at the actual download > from pypi. > > -This is a Python package (it produces no compiled binaries), so it should > be flagged as noarch using BuildArch: noarch. This will also get rid of the > empty debuginfo package. > > -Other than that, rpmlint identified a couple of other minor issues in both > RPMs that should be easy to fix: > > github-cli.src: W: summary-not-capitalized C command-line interface to the > GitHub Issues API > github-cli.src: W: spelling-error %description -l en_US ghi -> ghee, hi, chi > github-cli.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line > 1) > github-cli.src: W: invalid-url Source0: github-cli-1.0.0.tar.gz > > github-cli.x86_64: W: summary-not-capitalized C command-line interface to > the GitHub Issues API > github-cli.x86_64: E: no-binary > github-cli.x86_64: W: no-documentation > github-cli.x86_64: W: no-manual-page-for-binary ghi > github-cli-debuginfo.x86_64: E: empty-debuginfo-package I added all the fixes that u suggested: Spec URL: http://alvesadrian.fedorapeople.org/github-cli.spec SRPM URL: http://alvesadrian.fedorapeople.org/github-cli-1.0.0-2.fc16.src.rpm
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review