[Bug 822585] Review Request: perl-Module-Install-Repository - Automatically sets repository URL from svn/svk/Git checkout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Comment # 2 from
> I just gave a try, `find inc -type f \! -name 'Repository.pm'' made the build
> system happy.
I forgot to remove the files. It really does not work so straight-forward.

One solution is to:
(1) Remove inc
(2) Comment the auto_set_repository in Makefile.PL
(3) Run perl Makefile.PL
(4) Remove inc/.author
(5) Copy lib/Modules/Install/Repository.pm to inc
(6) Enable the auto_set_repository in Makefile.PL
(7) Run perl Makefile.PL again

Shorter solution is just to remove auto_set_repository from Makefile.PL because
the only outcome of the reflexive cycle is put proper VCS URL into META.yml
which we do not package either. Do not forget removing the autocreated
inc/.author, so that xt/* tests would not run.

More thorough solution is to guard removing auto_set_repository from
Makefile.Pl by perl_bootstrap macro because this extension becomes available
after building this package.

I like most the second solution (dropping auto_set_repository from Makefile.PL
unconditionally).


You are receiving this mail because:
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]