Comment # 1
from Petr Pisar
Source file is original. Ok. Summary verified from lib/Module/Install/Repository.pm. Ok. License verified from lib/Module/Install/Repository.pm. Ok. URL and Source0 are usable Ok. Description verified from lib/Module/Install/Repository.pm. Ok. no XS code, noarch BuildArch is Ok. TODO: Build-require `perl(base)' (lib/Module/Install/Repository.pm:8). TODO: Build-require `perl(File::Temp)' (t/01_find_repo.t:7). FIX: Build-require all dependencies of inc/* (like `perl(threads::shared)' at inc/Test/Builder.pm:24) or unbundle modules that can be unbundled. I just gave a try, `find inc -type f \! -name 'Repository.pm'' made the build system happy. TODO: You can run-require git, svn, darcs, hg, and svk as they can be used at run-time (lib/Module/Install/Repository.pm). All tests pass. Ok. $ rpmlint perl-Module-Install-Repository.spec ../SRPMS/perl-Module-Install-Repository-0.06-1.fc18.src.rpm ../RPMS/noarch/perl-Module-Install-Repository-0.06-1.fc18.noarch.rpm perl-Module-Install-Repository.src: W: spelling-error Summary(en_US) svn -> sen, sin, son perl-Module-Install-Repository.src: W: spelling-error Summary(en_US) svk -> Sven perl-Module-Install-Repository.noarch: W: spelling-error Summary(en_US) svn -> sen, sin, son perl-Module-Install-Repository.noarch: W: spelling-error Summary(en_US) svk -> Sven 2 packages and 1 specfiles checked; 0 errors, 4 warnings. FIX: Capitalize `svn' and `svk' in these are names of version control systems like a Git. $ rpm -q -lv -p ../RPMS/noarch/perl-Module-Install-Repository-0.06-1.fc18.noarch.rpm drwxr-xr-x 2 root root 0 May 21 15:47 /usr/share/doc/perl-Module-Install-Repository-0.06 -rw-r--r-- 1 root root 686 Aug 13 2009 /usr/share/doc/perl-Module-Install-Repository-0.06/Changes -rw-r--r-- 1 root root 588 Mar 19 2009 /usr/share/doc/perl-Module-Install-Repository-0.06/README -rw-r--r-- 1 root root 2219 May 21 15:47 /usr/share/man/man3/Module::Install::Repository.3pm.gz drwxr-xr-x 2 root root 0 May 21 15:47 /usr/share/perl5/vendor_perl/Module drwxr-xr-x 2 root root 0 May 21 15:47 /usr/share/perl5/vendor_perl/Module/Install -rw-r--r-- 1 root root 3158 Aug 13 2009 /usr/share/perl5/vendor_perl/Module/Install/Repository.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-Module-Install-Repository-0.06-1.fc18.noarch.rpm |sort |uniq -c 1 perl >= 0:5.005 1 perl(base) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(Module::Install::Base) 1 perl(strict) 1 perl(vars) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-Module-Install-Repository-0.06-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Module::Install::Repository) = 0.06 1 perl-Module-Install-Repository = 0.06-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-Module-Install-Repository-0.06-1.fc18.noarch.rpm rawhide/primary_db | 14 MB 00:01 Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4091385). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review