Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808884 --- Comment #2 from Iain Arnell <iarnell@xxxxxxxxx> 2012-05-19 11:06:59 EDT --- (In reply to comment #1) > > FIX: Build-require `perl(inc::Module::Install)' (Makefile.PL:3) instead of > `perl(ExtUtils::MakeMaker)'. > > TODO: Consider removing bundled Perl modules under inc/ and build-requiring > appropriate modules like Module::Install::AuthorTests. Otherwise you need > explicitly build-require all dependencies of inc/* code. > > FIX: Build-require modules used by code under inc/ (ExtUtils::Manifest, > YAML::Tiny, etc.). I really recommend unbundling inc/*. Oh! This is new. I'm not convinced that avoiding bundled Module::Install is the way to go here. The packaged inc::Module::Install even states # This module ONLY loads if the user has manually installed their own # installation of Module::Install, and are some form of MI author. The additional dependencies under inc/ are either optional (e.g. YAML::Tiny for writing MYMETA.yml which we don't need) or already pulled in by EU::MM. Since Module::Install is intended to work with nothing more than core perl installed, I don't see any reason to explicitly mention dependencies unless there's an unbundled core module missing that causes build failure. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review