Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=808884 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-04 08:05:18 EDT --- Source file is original. Ok. URL and Source0 are usable. Ok. Summary verified from lib/Data/Clone.pm. Ok. License verified from lib/Data/Clone.pm. Ok. Description verified from lib/Data/Clone.pm. Ok. Package compiles XS code, the architecture specific BuildArch is Ok. All releases provides perl(Test::More) >= 0.88, nonqualified build-require is Ok. All releases provides perl(Test::Release) >= 0.03, nonqualified build-require is Ok. FIX: Build-require `perl(inc::Module::Install)' (Makefile.PL:3) instead of `perl(ExtUtils::MakeMaker)'. TODO: Consider removing bundled Perl modules under inc/ and build-requiring appropriate modules like Module::Install::AuthorTests. Otherwise you need explicitly build-require all dependencies of inc/* code. FIX: Build-require modules used by code under inc/ (ExtUtils::Manifest, YAML::Tiny, etc.). I really recommend unbundling inc/*. TODO: Build-require `perl(threads)' for optional tests (t/10_threads.t:4). TODO: Build-require `perl(constant)' which can dual-live in the future (t/10_threads.t:4). All tests pass. Ok. $ rpmlint perl-Data-Clone.spec ../SRPMS/perl-Data-Clone-0.003-1.fc18.src.rpm ../RPMS/x86_64/perl-Data-Clone-* perl-Data-Clone.x86_64: W: devel-file-in-non-devel-package /usr/lib64/perl5/vendor_perl/auto/Data/Clone/data_clone.h 3 packages and 1 specfiles checked; 0 errors, 1 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Data-Clone-0.003-1.fc18.x86_64.rpm drwxr-xr-x 2 root root 0 May 4 13:51 /usr/lib64/perl5/vendor_perl/Data -rw-r--r-- 1 root root 5187 Jan 15 2011 /usr/lib64/perl5/vendor_perl/Data/Clone.pm drwxr-xr-x 2 root root 0 May 4 13:51 /usr/lib64/perl5/vendor_perl/auto/Data drwxr-xr-x 2 root root 0 May 4 13:51 /usr/lib64/perl5/vendor_perl/auto/Data/Clone -rwxr-xr-x 1 root root 14688 May 4 13:51 /usr/lib64/perl5/vendor_perl/auto/Data/Clone/Clone.so -rw-r--r-- 1 root root 365 Jan 15 2011 /usr/lib64/perl5/vendor_perl/auto/Data/Clone/data_clone.h drwxr-xr-x 2 root root 0 May 4 13:51 /usr/share/doc/perl-Data-Clone-0.003 -rw-r--r-- 1 root root 291 Jan 15 2011 /usr/share/doc/perl-Data-Clone-0.003/Changes -rw-r--r-- 1 root root 505 Jan 15 2011 /usr/share/doc/perl-Data-Clone-0.003/README -rw-r--r-- 1 root root 3680 May 4 13:51 /usr/share/man/man3/Data::Clone.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Data-Clone-0.003-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.11)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl >= 0:5.008_001 2 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(parent) 1 perl(strict) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) TODO: Do not explicitly run-require auto-discovered perl(Exporter). $ rpm -q --provides -p ../RPMS/x86_64/perl-Data-Clone-0.003-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(Data::Clone) = 0.003 1 perl-Data-Clone = 0.003-1.fc18 1 perl-Data-Clone(x86-64) = 0.003-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Data-Clone-0.003-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4052488). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed issues, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review