[Bug 823071] Review Request: php-symfony2-Form - Symfony2 Form Component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=823071

Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxxxxxxxxx

--- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2012-05-19 02:50:18 EDT ---
Just a quick notes

- LICENSE and README file are installed in /usr/share/pear.

Probably a good idea to ask upstream, this files should be tagged as "doc" and
so installed in /usr/share/doc/pear (and avoid to be duplicated in the package)

- Extension dependencies

# phpci print --recursive --report extension Symfony
-------------------------------------------------------------------------------
PHP COMPAT INFO EXTENSION SUMMARY
-------------------------------------------------------------------------------
  EXTENSION                                        PECL   VERSION         COUNT
-------------------------------------------------------------------------------
  Core                                                    4.0.0             309
  SPL                                                0.2  5.0.0               5
  ctype                                                   4.0.4               3
  date                                                    4.0.0              10
  intl                                             1.1.0  5.2.4              12
  pcre                                                    4.0.0              13
  session                                                 4.0.0               3
  standard                                                4.0.0             689
-------------------------------------------------------------------------------

So need to requires php-intl

- Other classes dependencies

>From package.xml => ok
Requires:       php-pear((%{pear_channel}/EventDispatcher)
Requires:       php-pear((%{pear_channel}/Validator)
Requires:       php-pear((%{pear_channel}/Locale)

And optionnaly (your decision) 
Requires:       php-pear((%{pear_channel}/HttpFoundation)

- directory ownership

%dir %{pear_phpdir}/Symfony/Component
%dir %{pear_phpdir}/Symfony

You don't need to own this directories which are already owned by required
packages.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]