Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=823043 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxx --- Comment #1 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> 2012-05-19 02:31:57 EDT --- Just a quick notes - LICENSE and README file are installed in /usr/share/pear. Probably a good idea to ask upstream, this files should be tagged as "doc" as so installed in /usr/share/doc/pear (and avoid to be duplicated in the package) - dependencies # phpci print --recursive --report extension Symfony ------------------------------------------------------------------------------- PHP COMPAT INFO EXTENSION SUMMARY ------------------------------------------------------------------------------- EXTENSION PECL VERSION COUNT ------------------------------------------------------------------------------- Core 4.0.0 214 mbstring 4.0.6 4 pcre 4.0.0 14 posix 306939 4.0.0 1 readline 2.0.1 4.0.0 6 standard 4.0.0 367 ------------------------------------------------------------------------------- Reading the code, mbstring and posix are optional (detected at runtime), but I think it could be usefull to add them in the package requires. - Requires: php >= 5.3.2 Please, don't do that. Requiring php will pull apache. A library (especially a "console" one) don't need a webserver. To set the minimal php version, please use Requires: php-common >= 5.3.2 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review