Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: x86info https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226547 ------- Additional Comments From rafalzaq@xxxxxxxxx 2007-02-03 19:42 EST ------- Things to fix: * rpmlint -v returns: I: x86info-debuginfo checking W: x86info-debuginfo no-version-in-last-changelog W: x86info-debuginfo no-url-tag I: x86info checking W: x86info summary-not-capitalized x86 processor information tool. W: x86info summary-ended-with-dot x86 processor information tool. W: x86info no-version-in-last-changelog W: x86info no-url-tag E: x86info obsolete-not-provided kernel-utils I: x86info checking W: x86info summary-not-capitalized x86 processor information tool. W: x86info summary-ended-with-dot x86 processor information tool. W: x86info no-url-tag W: x86info unversioned-explicit-obsoletes kernel-utils W: x86info rpm-buildroot-usage %build rm -rf $RPM_BUILD_ROOT W: x86info rpm-buildroot-usage %build mkdir -p %{buildroot}/usr/sbin E: x86info no-cleaning-of-buildroot %install W: x86info mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 5) * Release tag should be more legible * no URL tag * you must use one of the following Changelog formats: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b7d622f4bb245300199c6a33128acce5fb453213 * preferred BuildRoot value is %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * you must choose one of the Build Root values: http://fedoraproject.org/wiki/Packaging/Guidelines#head-f3d77b27a5d29dfc1f5600ef3fc836f2e317badf * make should use %{?_smp_mflags} flag * you don't need to use %setup -c -a 0 and cd x86info-%{version} * you should use rm -rf $RPM_BUILD_ROOT (or rm -rf %{buildroot}) to clean out the install & clean sections * %{buildroot}/usr/share/man/man8 is not used, does it really needed? * COPYING, README and TODO files must be included in %doc * x86info binary must be in %{_sbindir} instead of /usr/sbin/ * Source tag should include direct path to the file (URL) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review