Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: fribidi https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225771 roozbeh@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|roozbeh@xxxxxxxxxxxxx |caolanm@xxxxxxxxxx CC| |roozbeh@xxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From roozbeh@xxxxxxxxxxxxx 2007-02-03 19:37 EST ------- GOOD ==== MUST: rpmlint output fine: $ rpmlint fribidi-devel-0.10.7-5.1.i386.rpm W: fribidi-devel no-documentation MUST: spec filename matches %{name} MUST: package is free software MUST: License matches actual license (LGPL) MUST: text of license in both upstream and package as %doc MUST: spec file legible MUST: no ExcludeArch MUST: BuildRequires assumed fine MUST: no localization MUST: ldconfig used fine MUST: not relocatable MUST: owned dirs fine (-devel creates /usr/lib and depends on pkgconfig which owns it) MUST: no dup files MUST: clean section fine MUST: macro use consistent MUST: contains code MUST: no large documentation MUST: %docs don't affect runtime MUST: header files and static libs in -devel MUST: -devel which has *.pc Req's pkgconfig\ MUST: *.la explicitly removed MUST: not GUI MUST: does not own other's dirs SHOULD: no scriptlets SHOULD: no subpackages other than -devel SHOULD: *.pc files in -devel BAD === MUST: Package Naming Guidelines * release should use integers and dist-tags. should be changed to 6%{?dist} MUST: Packaging Guidelines * BuildRoot should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * "make" should be changed to "make %{?_smp_mflags}" * "%makeinstall" should be changed to "make DESTDIR=$RPM_BUILD_ROOT install" MUST: US English * FriBidi should be spelled with capital F and B in summary and description field of -devel subpackage. * Hebrew and Arabic should be spelled with capital H and A in descriptionp of main package. * "eg." should be changed to "e.g." or better, "for example": "for example Arabic and Hebrew"). * Static library (*.a) should not be packaged unless there is a very good reason for packaging it. MUST: source to match upstream * source matches upstream (md5sum checked) but Source: should be change to include the full URL: http://fribidi.org/download/fribidi-[...] MUST: file permissions * Please use %defattr(-,root,root,-) instead of %defattr(-,root,root) (it's used twice). MUST: devel packages must require fully versioned dependency * -devel should do this instead of just %{name} = %{version}: Requires: %{name} = %{version}-%{release} -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review