Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812583 --- Comment #10 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-14 03:52:42 EDT --- Spec file changes: --- perl-FusionInventory-Agent-Task-NetInventory.spec.old 2012-05-09 15:02:32.519999974 +0200 +++ perl-FusionInventory-Agent-Task-NetInventory.spec 2012-05-14 09:24:17.161998991 +0200 @@ -1,6 +1,6 @@ Name: perl-FusionInventory-Agent-Task-NetInventory Version: 2.1 -Release: 2%{?dist} +Release: 3%{?dist} Summary: Remote inventory support for FusionInventory Agent License: GPLv2+ Group: Development/Libraries @@ -20,26 +20,26 @@ BuildRequires: perl(threads) BuildRequires: perl(threads::shared) BuildRequires: perl(Encode) -BuildRequires: perl(FusionInventory::Agent::Task::NetDiscovery) >= 2.1 -BuildRequires: perl(FusionInventory::Agent::Task) -BuildRequires: perl(FusionInventory::Agent::SNMP) -BuildRequires: perl(FusionInventory::Agent::XML::Query) -BuildRequires: perl(FusionInventory::Agent::Tools) -BuildRequires: perl(FusionInventory::Agent::Tools::Network) -BuildRequires: perl(FusionInventory::Agent::XML::Response) +BuildRequires: perl-FusionInventory-Agent-Task-NetDiscovery >= 2.1 -Requires: perl(FusionInventory::Agent::Task::NetDiscovery) >= 2.1 +Requires: perl-FusionInventory-Agent-Task-NetDiscovery >= 2.1 Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) # upstream have rename from SNMPQuery 1.3 to NetInventory 2.0 Obsoletes: perl-FusionInventory-Agent-Task-SNMPQuery < 2.0 Provides: perl-FusionInventory-Agent-Task-SNMPQuery = %{version}-%{release} +# RPM 4.8 +%{?filter_from_provides: %filter_from_provides /perl(FusionInventory::/d} +%{?filter_from_requires: %filter_from_requires /perl(FusionInventory::/d} %{?perl_default_filter} +# RPM 4.9 +%global __provides_exclude %{?__provides_exclude:__provides_exclude|}^perl\\(FusionInventory:: +%global __requires_exclude %{?__requires_exclude:__requires_exclude|}^perl\\(FusionInventory:: %description -This task allows the FusionInventory agent to extracts various informations +This task allows the FusionInventory agent to collect information from remote hosts through SNMP protocol: * printer cartridges and counters status * router/switch ports status @@ -90,6 +90,10 @@ %changelog +* Fri May 11 2012 Remi Collet <remi@xxxxxxxxxxxxxxxxx> - 2.1-3 +- filter private provides/requires +- fix description (in sync with upstream) + * Mon May 07 2012 Remi Collet <remi@xxxxxxxxxxxxxxxxx> - 2.1-2 - changes from review (#812583) > TODO: Correct invalid word `informations' in the description. English has > `information' always in singular. Plural is `data'. So I think grammatically > correct sentence is `... to extracts various data...'. %description -This task allows the FusionInventory agent to extracts various informations +This task allows the FusionInventory agent to collect information Ok. -BuildRequires: perl(FusionInventory::Agent::Task) -BuildRequires: perl(FusionInventory::Agent::XML::Query) -BuildRequires: perl(FusionInventory::Agent::Tools) -BuildRequires: perl(FusionInventory::Agent::Tools::Network) -BuildRequires: perl(FusionInventory::Agent::XML::Response) FIX: Now, you should depend on `FusionInventory-Agent'. -BuildRequires: perl(FusionInventory::Agent::Task::NetDiscovery) >= 2.1 -BuildRequires: perl(FusionInventory::Agent::SNMP) +BuildRequires: perl-FusionInventory-Agent-Task-NetDiscovery >= 2.1 Ok. $ rpmlint perl-FusionInventory-Agent-Task-NetInventory.spec ../SRPMS/perl-FusionInventory-Agent-Task-NetInventory-2.1-3.fc18.src.rpm ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-3.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Ok. > FIX: If you do not relocate the fusioninventory-agent Perl modules to standard > path, remove the `perl(FusionInventory::Agent::*' dependencies because they > are private. Then you will need to depend on fusioninventory-agent symbol. $ rpm -q --requires -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-3.fc18.noarch.rpm | sort | uniq -c 1 perl(base) 1 perl(constant) 1 perl(Encode) 1 perl(English) 1 perl-FusionInventory-Agent-Task-NetDiscovery >= 2.1 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(threads) 1 perl(threads::shared) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Require `FusionInventory-Agent' because it uses modules from that package. > FIX: Remove these private `perl(FusionInventory::Agent::Task::NetInventory' > Provides, if you do not relocate the files into standard path. $ rpm -q --provides -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-3.fc18.noarch.rpm | sort | uniq -c 1 perl-FusionInventory-Agent-Task-NetInventory = 2.1-3.fc18 1 perl-FusionInventory-Agent-Task-SNMPQuery = 2.1-3.fc18 Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4075228). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' prefixed item and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review