[Bug 820542] Review Request: libguac - The common library used by all C components of Guacamole

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=820542

--- Comment #10 from Simone Caronni <negativo17@xxxxxxxxx> 2012-05-14 03:34:01 EDT ---
Spec URL:http://slaanesh.fedorapeople.org/libguac.spec
SRPM URL: http://slaanesh.fedorapeople.org/libguac-0.6.0-3.fc17.src.rpm

Hello,

thanks for the inputs. I've added the following:

- Removed generated latex files from doxygen into libguac-devel.
- Added LIBS="-lrt" to configure.
- Added to first line of %install: INSTALL="install -p"
- Removed CFLAGS; I will ask upstream post-review to implement all changes
resulted from the package reviews for all packages in the Guacamole stack.

I don't know how to change the following though, it's the package name:

$ rpmlint libguac-*
libguac.src: W: spelling-error %description -l en_US guacd -> guard
libguac.x86_64: W: spelling-error %description -l en_US guacd -> guard
4 packages and 0 specfiles checked; 0 errors, 2 warnings.

And this:

> * Running rpmlint on the install libguac-devel package (not the rpm) says:
>
>  libguac-devel.x86_64: W: doc-file-dependency
> /usr/share/doc/libguac-devel-0.6.0/html/installdox /usr/bin/perl
>
>  You probably don't want to install the installdox script.

There's no "installdox" script packaged into libguac-devel, what does it mean?

Thanks,
--Simone

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]