[Bug 662269] Review Request: dpic - A compiler for the pic language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=662269

--- Comment #8 from Ben Boeckel <mathstuf@xxxxxxxxx> 2012-05-08 18:13:57 EDT ---
(In reply to comment #7)
> Indeed, I get those rpmlint complaints and they're all fine.  (Though I wonder
> why all of the stuff in the srpm has such odd permissions.  I guess it could be
> your umask.)

Yeah, I use 027 as my umask.

> The "texlive2010" bit is a little odd since that project is on to texlive2012
> now.  Hopefully one day soon that project will actually be finished.  (Last I
> checked it was waiting on just two license issues.)  Anyway, that's 

…an incomplete sentence ;) . I didn't know texlive2012 was that close. I know
jnovy fedorapeople repo hasn't been updated in a long time, but I haven't seen
any reviews going by.

> Since the package contains files of multiple licenses, you'll need at least a
> comment in the spec indicating which file is under which license.

Ah, yeah.

> The examples package has a somewhat odd directory structure; the "examples"
> directory is repeated:
>   /usr/share/dpic/examples/examples/README
> I also wonder if the documentation for the examples should be packaged as
> documentation, though that's starting to descend to absurdity.

Hmm, I'll get rid of the duplicate examples thing. Must have skimmed that when
looking at the path lists.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]