Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818454 --- Comment #3 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxx> 2012-05-07 09:23:37 EDT --- Thank you for comments! (In reply to comment #2) > - License is GPLv2+, not just GPLv2 (try running licensecheck on COPYING or > linecache19.rb). So please check the above comment on License: line > - The "gem build" should probably be moved to the %build section according to > the guidelines example [1]. I want to clean up unneeded directory on %prep, so I prefer to once "prepare" gem file at %prep. > - In %check section, the pushd should be associated with popd. Well, not necessary... > - You can run the tests more easily with "testrb -Ilib test/test-*". Thank you for information. > - As for the docs, I would leave COPYING and possibly README in the main > package and move the rest into the doc subpackage. Well, this is already done... > - I would also consider marking the files, that actually are documents, by %doc > in -doc subpackage, but this is not a blocker. > - Is there any specific reason why the -doc subpackage is not marked as noarch? > If not, please make it noarch. http://lists.fedoraproject.org/pipermail/packaging/2012-May/008401.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review