Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=818454 --- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda@xxxxxxxxxx> 2012-05-07 08:40:26 EDT --- - License is GPLv2+, not just GPLv2 (try running licensecheck on COPYING or linecache19.rb). - The "gem build" should probably be moved to the %build section according to the guidelines example [1]. - In %check section, the pushd should be associated with popd. - You can run the tests more easily with "testrb -Ilib test/test-*". - As for the docs, I would leave COPYING and possibly README in the main package and move the rest into the doc subpackage. - I would also consider marking the files, that actually are documents, by %doc in -doc subpackage, but this is not a blocker. - Is there any specific reason why the -doc subpackage is not marked as noarch? If not, please make it noarch. [1] https://fedoraproject.org/wiki/Packaging:Ruby#.25build -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review