[Bug 759855] Review Request: sslh - A SSL/SSH multiplexer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=759855

Andreas Thienemann <andreas@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |andreas@xxxxxxxxx

--- Comment #17 from Andreas Thienemann <andreas@xxxxxxxxx> 2012-05-05 06:35:02 EDT ---
I noticed you are using the following statements to disable the service in
rhel:

%if 0%{?rhel}
 if [ $1 = 0 ]; then
  /etc/init.d/sslh stop
  rm -f /etc/init.d/sslh
%endif

I would suggest continuing the "usual" practice of using chkconfig and service
to do this:

postinst (which is missing) should be:

/sbin/chkconfig --add sslh

and preuninstall can be:

if [ $1 = 0 ]; then
 /sbin/service sslh stop > /dev/null 2>&1
 /sbin/chkconfig --del sslh
fi

This not only deletes the initscript but also all the symlinks pointing to it
in the different runlevels.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]