Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: cpio https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225656 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|ruben@xxxxxxxxxxxxxxxx |pvrabec@xxxxxxxxxx CC| |ruben@xxxxxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-03 13:09 EST ------- * RPM name is OK * Source cpio-2.6.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * BuildRequires: gettext is missing (required to build the translations) * The %makeinstall macro should not be used (wiki: PackagingGuidelines#MakeInstall) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) * Please preserve timestamps when installing files rpmlint is not silent: [ruben@odin cpio]$ rpmlint cpio-2.6-23.fc6.src.rpm W: cpio prereq-use /sbin/rmt W: cpio prereq-use /sbin/install-info Use Requires(post) and Requires(preun) instead W: cpio mixed-use-of-spaces-and-tabs (spaces: line 99, tab: line 3) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review